Use vscode builtin extensions v1.70.2 #12283
Conversation
marcdumais-work
added
test
marcdumais-work
force-pushed
the
use-builtins-1.70.2
branch
2 times, most recently
from
3fa2181 to
72a2bf9
Compare
marcdumais-work
force-pushed
the
use-builtins-1.70.2
branch
5 times, most recently
from
0b15ddf to
25f1cdd
Compare
|
The extension pack 1.70.2 bundles both |
Indeed - I accidentally forgot to update the script that creates the extension pack, when I published the builtins v1.70.2 (it will be for the next release). I am doing the change you suggest, as we speak. |
Some time between 1.66.2 and 1.70.2, the references-view extension "ms-vscode.references-view" has gone from a standalone extension, that has its own repository, to a vscode built-in extension, that's part of the vscode repository. With that change, the extension's publisher has been updated from "ms-vscode" to "vscode". As of 1.70.2, this extension is referenced in the builtins extension pack and no longer needs to be specifically referenced in `package.json`. This PR contains the following: Example application: - update the builtin extension pack to v1.70.2 - remove entry for old `references-view` extension, add it to "theiaPluginsExcludeIds" - remove pinning for typescript extensions. typescript browser tests: - use new publisher when referencing `references-view` builtin - re-try sending "Escape" to close the peek widget if it remains opened Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
force-pushed
the
use-builtins-1.70.2
branch
from
25f1cdd to
5d39b84
Compare
@vince-fugnitto builtins 1.70.2 are published. I have added an entry in |
What it does
Some time between 1.66.2 and 1.70.2, the references-view extension "ms-vscode.references-view" has gone from a standalone extension, that has its own repository, to a vscode built-in extension, that's part of the vscode repository. With that change, the extension's publisher has been updated from "ms-vscode" to "vscode". As of 1.70.2, this extension is referenced in the builtins extension pack and no longer needs to be specifically referenced in
package,json.This PR contains the following:
Example application:
references-viewextension, add it to "theiaPluginsExcludeIds"typescript browser tests:
references-viewbuiltinHow to test
Note: This PR is expected to fail CI until the vscode builtins v1.70.2 are published to
openvsx.org. Once that's done, we should be able to fetch the new builtin pack and the extensions it refers-to, including the recently renamedvscode.references-viewextension, usingyarn download:plugins.To test:
Review checklist
Reminder for reviewers